use libcurl in getdeps (#487) - Githubissues

facebookarchive / bistro

Bistro is a flexible distributed scheduler, a high-performance framework supporting multiple paradigms while retaining ease of configuration, management, and monitoring.

https://bistro.io

MIT License

1.04k stars 158 forks source link

use libcurl in getdeps (#487) #60

Closed dgrnbrg-meta closed 2 years ago

dgrnbrg-meta commented 2 years ago

Summary: X-link: https://github.com/facebook/fbthrift/pull/487

X-link: https://github.com/facebook/fboss/pull/114

X-link: https://github.com/facebook/fb303/pull/27

When using getdeps inside of a container, Python's urllib isn't able to download from dewey lfs (see this post for details https://fb.workplace.com/groups/systemd.and.friends/permalink/2747692278870647/).

This allows for getdeps to use libcurl to fetch dependencies, which allows for a getdeps build to work inside the container environment.

Reviewed By: mackorone

Differential Revision: D34696330

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D34696330