search

facebookarchive / caffe2

Caffe2 is a lightweight, modular, and scalable deep learning framework.
https://caffe2.ai
Apache License 2.0
8.42k stars 1.95k forks source link

hiredis include path #1493

Open ghost opened 6 years ago

ghost commented 6 years ago

The CMakeCache.txtof Caffe2 exposes following variables:

HIREDIS_INCLUDE_DIRS
HIREDIS_LIBRARIES Hiredis_INCLUDE_DIR Hiredis_LIBRARIES

Hiredis.h exists in a folder like following :

<install_path>/include/hiredis/hiredis.h

When in include_dirs, I provide <install_path>/include/hiredis, I get an error in some files because they specify the include as #include<hiredis/hiredis.h>

When I provide <install_path>/include, I get an error in some files because they specify the include as #include<hiredis/hiredis.h>

I also tried to provide both the paths separated by a;in the ccmake, but the problem persists ?

What is the reason behind this inconsistency ?

pietern commented 6 years ago

Taking a look. Probably the caffe2 and gloo cmake files use them in a slightly different way...