facebookarchive / codemod

Codemod is a tool/library to assist you with large-scale codebase refactors that can be partially automated but still require human oversight and occasional intervention. Codemod was developed at Facebook and released as open source.
Apache License 2.0
4.12k stars 197 forks source link

Don't advance position if substitution is zero-length #100

Closed swolchok closed 6 years ago

swolchok commented 6 years ago

Fixes #33. Manually tested example in that issue.

I don't know if substitution functions can return something that doesn't have a len() and I'm not really familiar with the library use case, so please give that some thought/review!

modocache commented 6 years ago

Excellent, thanks @swolchok!