Closed rochacbruno closed 8 years ago
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!
I just signed the CLA
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
Woah, this is awesome! Thanks, @rochacbruno, this seems like a massive improvement. Just a few notes...
So, so cool. :sunglasses:
Just had the two questions about noqa
and the doctest argument. I'll merge once those are addressed. Thanks!! :+1:
Thanks! :100:
make test
If merging: