search

facebookarchive / codemod

Codemod is a tool/library to assist you with large-scale codebase refactors that can be partially automated but still require human oversight and occasional intervention. Codemod was developed at Facebook and released as open source.
Apache License 2.0
4.11k stars 198 forks source link

New PyPI release? #81

Closed rouge8 closed 7 years ago

rouge8 commented 7 years ago

Any chance of tagging and pushing a new release?

modocache commented 7 years ago

@kastiglione I think you did this before... :)

modocache commented 7 years ago

No wait, it was @rochacbruno :)

rochacbruno commented 7 years ago

@modocache I think I did it once

rochacbruno commented 7 years ago

BTW: @modocache looks like I lost my access to this org

rochacbruno commented 7 years ago

@modocache I sent you an email about getting access to repo again, So I can bump version and release to Pypi.

(also please tell me your PyPI username so I can add you there as maintainer look #66)

modocache commented 7 years ago

Replied to your email!

OK, no way around it -- I think I'll have to update PyPI this time. I'll also take care of #66 while I'm at it. Thanks, @rochacbruno!

rouge8 commented 7 years ago

Anyone ever have any luck? :)

rochacbruno commented 7 years ago

@rouge8 @modocache the PyPI package is under my ownership and I want to add someone else as owner/maintainer. Please give me yourr PyPI username and I can do that, and then you can control the releases.

keyan commented 7 years ago

@modocache -- I know the new contributor guidelines don't allow for us to be members, but if it is okay with you I am happy to take ownership for the PyPi package so I can update the release. One doesn't need repo access to update the package.

@rochacbruno my PyPi username is keyanp

modocache commented 7 years ago

Sounds fine to me! Yeah, a new release would be great.

rochacbruno commented 7 years ago

@keyan added https://pypi.python.org/pypi/codemod now you have permission to python setup.py sdist upload

rochacbruno commented 7 years ago

@keyan BTW you will need access to repo to bump the version. It would be better if @modocache releases, it is just a matter of bumping the version on setup.py and running python setup.py sdist upload

We can also setup travis CI to release to PyPI automatically when a tagged PR passes.

@modocache what is your PyPI username?

modocache commented 7 years ago

Should we revert the README to the instructions that had users install via pip install git+https://github.com/facebook/codemod.git? It seems like that would be easier than coordinating PyPI releases. As far as I can tell, it just adds overhead...? Please correct me if I'm wrong.

My PyPI username is B.G, I think I chose that name, like, 6 years ago. I wish I could change it...

keyan commented 7 years ago

@keyan BTW you will need access to repo to bump the version.

For now I just opened a PR to bump the version. The only thing I can't do without access is make a new github tag.

We can also setup travis CI to release to PyPI automatically when a tagged PR passes.

Reading through https://docs.travis-ci.com/user/deployment/pypi/ it seems to me that we would have to tag a commit so I'd still need write access to the repo.

Should we revert the README to the instructions that had users install via pip install git+https://github.com/facebook/codemod.git? It seems like that would be easier than coordinating PyPI releases. As far as I can tell, it just adds overhead...? Please correct me if I'm wrong.

I'm personally in favor of keeping the PyPI releases because it is easier to install/manage packages this way than manually installing the repo. It does add some overhead, but I'm fine maintaining for now at least.

rouge8 commented 7 years ago

@modocache @keyan I don't actually see the new release on PyPI?

keyan commented 7 years ago

Hey @rouge8 -- that was because my PR wasn't merged until the weekend and I was offline :)

Uploaded it just a few minutes ago!