facebookarchive / contest

Run continuous and on-demand system testing for real and virtual hardware
MIT License
32 stars 15 forks source link

Add Storage.Close method #269

Closed rojer9-fb closed 3 years ago

rojer9-fb commented 3 years ago

To ensure all pending events are flushed when server shuts down.

Signed-off-by: Deomid "rojer" Ryabkov rojer9@fb.com

codecov[bot] commented 3 years ago

Codecov Report

Merging #269 (7232264) into master (be1b324) will decrease coverage by 0.05%. The diff coverage is 68.04%.

:exclamation: Current head 7232264 differs from pull request most recent head 6dc737c. Consider uploading reports for the commit 6dc737c to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage   66.40%   66.34%   -0.06%     
==========================================
  Files         125      125              
  Lines        5965     5999      +34     
==========================================
+ Hits         3961     3980      +19     
- Misses       1530     1550      +20     
+ Partials      474      469       -5     
Flag Coverage Δ
e2e 45.22% <47.82%> (-0.02%) :arrow_down:
integration 60.08% <67.05%> (+0.13%) :arrow_up:
unittests 43.29% <29.16%> (-0.12%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/storage/rdbms/list_jobs.go 77.14% <ø> (-1.24%) :arrow_down:
plugins/targetmanagers/csvtargetmanager/csvfile.go 1.16% <ø> (ø)
plugins/targetmanagers/targetlist/targetlist.go 52.17% <ø> (ø)
tests/integ/common/storage.go 62.50% <0.00%> (-2.72%) :arrow_down:
pkg/storage/storage.go 42.10% <33.33%> (+13.53%) :arrow_up:
tests/integ/jobmanager/common.go 90.04% <40.00%> (-0.49%) :arrow_down:
plugins/storage/rdbms/init.go 51.72% <60.52%> (-6.74%) :arrow_down:
cmds/contest/server/server.go 59.52% <75.00%> (+0.90%) :arrow_up:
pkg/jobmanager/jobmanager.go 78.19% <100.00%> (-0.55%) :arrow_down:
pkg/jobmanager/status.go 60.46% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be1b324...6dc737c. Read the comment docs.