search

facebookarchive / contest

Run continuous and on-demand system testing for real and virtual hardware
MIT License
32 stars 15 forks source link

Add targets parameter to TargetManager.Release method #270

Closed rihter007 closed 3 years ago

rihter007 commented 3 years ago

Simple first step to add targets to Release method. After one can also add additional returned interface{} to Acquire() (targets, releaseParam, error) [We do already have a release parameter, so we should think of combining them]

codecov[bot] commented 3 years ago

Codecov Report

Merging #270 (5cf696e) into master (307dfa0) will increase coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   66.45%   66.56%   +0.11%     
==========================================
  Files         125      125              
  Lines        5959     5997      +38     
==========================================
+ Hits         3960     3992      +32     
- Misses       1531     1535       +4     
- Partials      468      470       +2
Flag Coverage Δ
e2e 45.58% <100.00%> (+0.29%) :arrow_up:
integration 59.82% <100.00%> (-0.09%) :arrow_down:
unittests 43.48% <0.00%> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/targetmanagers/csvtargetmanager/csvfile.go 1.16% <ø> (ø)
plugins/targetmanagers/targetlist/targetlist.go 52.17% <ø> (ø)
pkg/runner/job_runner.go 64.50% <100.00%> (ø)
pkg/cerrors/cerrors.go 16.66% <0.00%> (ø)
pkg/runner/test_runner.go 92.48% <0.00%> (ø)
pkg/transport/http/http.go 61.71% <0.00%> (+9.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 307dfa0...5cf696e. Read the comment docs.