search

facebookarchive / contest

Run continuous and on-demand system testing for real and virtual hardware
MIT License
32 stars 15 forks source link

fix(jobmanager): Use request's context to do logging #281

Closed xaionaro closed 3 years ago

xaionaro commented 3 years ago

I was confused when saw debug logs from jobmanager, but haven't seen debug logs from everything else. But then I realized they use different contexts. To avoid this confusion in future I propose to use the same context.

codecov[bot] commented 3 years ago

Codecov Report

Merging #281 (3c79e8c) into master (db80174) will decrease coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   67.52%   67.43%   -0.10%     
==========================================
  Files         136      136              
  Lines        6566     6566              
==========================================
- Hits         4434     4428       -6     
- Misses       1632     1639       +7     
+ Partials      500      499       -1
Flag Coverage Δ
e2e 44.92% <100.00%> (-0.21%) :arrow_down:
integration 57.32% <100.00%> (+0.13%) :arrow_up:
unittests 49.06% <ø> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/jobmanager/jobmanager.go 80.14% <100.00%> (ø)
pkg/runner/job_runner.go 68.75% <0.00%> (-3.52%) :arrow_down:
pkg/runner/test_runner.go 92.32% <0.00%> (+0.42%) :arrow_up:
pkg/cerrors/cerrors.go 16.66% <0.00%> (+16.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db80174...3c79e8c. Read the comment docs.