facebookarchive / contest

Run continuous and on-demand system testing for real and virtual hardware
MIT License
32 stars 15 forks source link

New reporter that can upload a file to a AWS S3 bucket. #296

Closed llogen closed 3 years ago

llogen commented 3 years ago

Here i suggest a new reporter that is able to upload a specific file to a S3 bucket. That could be expand to other S3 services. That feature can be very useful if a test contains building a binary and that binary should be automatically uploaded.

facebook-github-bot commented 3 years ago

Hi @llogen!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

tfg13 commented 3 years ago

hey there, thanks for the PR!

You'll have to figure out the CLA to make the bot happy :)

Regarding your code - I was wondering, should/can this be a test step instead of a result reporter? Just asking because it does not seem to depend on job results at all, and I can imagine a lot of test flows want to upload files. Then again, test steps can run per target - is this intended to only run once for all the DUTs in a tests?

llogen commented 3 years ago

Hi, your welcome :)

I contacted cla@fb.com to make the bot happy.

I was also thinking about creating this as a test step, but the idea was, that you can choose either you upload a file for each test using the RunReporter or just upload a file for the hole test using the FinalReporter. From my point of view that would not be possible as a test step. Please correct me if I am wrong!

tfg13 commented 3 years ago

No you are right, that makes sense. The RunReporter runs after all the tests steps are done. If you use more than one run (Runs: 2 or more), then the FinalReporter will run after all the repetitions are done.

llogen commented 3 years ago

Okay thank you! I am after the CLA signing.

tfg13 commented 3 years ago

Hey, I am afraid the bot is still not happy and I can't move this forward without :(

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!