facebookarchive / draft-js

A React framework for building text editors.
https://draftjs.org/
MIT License
22.58k stars 2.64k forks source link

Use draftjs.org domain? #317

Closed Daniel15 closed 7 years ago

Daniel15 commented 8 years ago

github.io subdomains look pretty tacky - It'd be like a professional company hosting their website on geocities.com :smile:

It looks like you've got the draftjs.org domain but it just redirects to facebook.github.io/draft-js/. IMO it'd look nicer to use draftjs.org as the domain for the site.

Secretmapper commented 8 years ago

I kinda agree, but I think keeping consistency between all of facebook's open source projects is better?

i.e. https://facebook.github.io/react/ https://facebook.github.io/relay/ https://facebook.github.io/react-native/

https://facebook.github.io/draft-js/ feels at home.

Daniel15 commented 8 years ago

That's not actually consistent though - As far as I know, more projects are using proper domains rather than subdomains. There's actually very few (other than React and Relay) that use .github.io subdomains. :smile:

Some examples: http://flowtype.org/ http://hacklang.org/ http://hhvm.com/ http://fbinfer.com/ http://nuclide.io/ http://fbredex.com/ http://rocksdb.org/ http://osquery.io/ http://buckbuild.com/ http://frescolib.org/

Especially for projects that already own a domain name (like draftjs.org in this case), it doesn't really make sense to use the tacky subdomain :smile:

Secretmapper commented 8 years ago

Ah proved me wrong :smile: For me draft-js still feels at home at github.io domains - that's probably just me being used to react projects having github.io subdomains though. Anyway that's just my two cents, and I don't really have particularly strong views one way or the other.

lacker commented 7 years ago

I think the consensus is that this would be handy but it's non-urgent. I'm going to close this issue but if someone at FB wants to volunteer to set this up then I think that would be great ;-)

Daniel15 commented 7 years ago

if someone at FB wants to volunteer to set this up

I'm happy to help, I just don't know who owns the domain. @hellendag Do you own the draftjs.org domain?

flarnie commented 7 years ago

Thanks @Daniel15! It sounds like @hellendag and @spicyj own the relevant domains and are supportive of this change. Leaving this closed since it sounds like it will be solved soon, but we can reopen if questions/concerns remain.

Daniel15 commented 7 years ago

I've moved the site over to the draftjs.org domain name. It's working!

I had to build the site manually as TravisCI is running way behind.

logicalphase commented 7 years ago

Looks good across devices and browsers I checked, including:

Android 7.1.1 Pixel Chrome Android 7.1.1 Nexus 5x Chrome Android 7.1.1 Pixel C Chrome Ubuntu 16.04 Chrome, Firefox LRs

On Feb 25, 2017 1:58 AM, "Daniel Lo Nigro" notifications@github.com wrote:

I've moved the site over to the draftjs.org domain name. It's working!

https://camo.githubusercontent.com/6990aa74b6b1852c3f9aa06b6101870298736b00/687474703a2f2f73732e64616e2e63782f323031372f30322f44726166742e6a735f5f526963685f546578745f456469746f725f4672616d65776f726b5f666f725f52656163745f2d5f5f32342d32332e35372e35322e706e67

I had to build the site manually as TravisCI is running way behind.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/facebook/draft-js/issues/317#issuecomment-282468261, or mute the thread https://github.com/notifications/unsubscribe-auth/AYC27VlxMNlJqFRtzYB0S-LcCf4la_a5ks5rf98vgaJpZM4IJFgF .