Indenting list block of one type inside the other

[jpuri]

If I create a OL of 2 items and change depth of 2nd item to 2, like this:

1. ITEM1
      2. ITEM2

If I change type of 2nd item to UL it looses it depth:

1. ITEM1

2. ITEM2

But now if I try to indent second item, it works

1. ITEM1

    2. ITEM2

While indenting its checked that block above is list, but its not checked if its list of same type. Also, please find gif attached. I can create a PR for the fix.

[jpuri]

[hellendag]

Thanks for the GIF -- very helpful. :)

I don't recall whether this was intentional, but block depth is always reset when setting type: https://github.com/facebook/draft-js/blob/master/src/model/transaction/setBlockTypeForContentState.js#L35

I'd be open to a PR to change this, since it seems reasonable to preserve depth on list items.

[ericbiewener]

I'm not sure how the OP created that GIF -- Draft doesn't create true nested lists. All nesting is an illusion accomplished purely via CSS:

And the corresponding DOM:

Perhaps this is a newer approach that was not in play when the OP posted?

[thibaudcolas]

This is reproducible in any editor that has the two list types, and that has a way to increase depth, https://draftjs.org/ shows the issue. There are two separate behaviours:

• Draft.js allows indenting different list items inside of one another (whether it's a bug or feature, up to interpretation)
• Draft.js resets the block depth to 0 when changing block type, even if the new block type can also be nested/indented. This happens regardless of whether different list items are nested in one-another or not. Definitely a bug.

GIF for the first behavior:

Second behaviour, the depth reset bug:

[cappuccino6]

Is there anybody teach me how to do this issue, thx very much