facebookarchive / duckling_old

Deprecated in favor of https://github.com/facebook/duckling
https://duckling.wit.ai
Other
1.32k stars 217 forks source link

Parsing breakfast/lunch/dinner to datetime #145

Open alvinthen opened 8 years ago

alvinthen commented 8 years ago

Not sure if this is a bug or unintended feature.

Trying to understand lunch using duckling returns a time from 1200 to 1400, while breakfast/dinner returns nothing.

It would be great to be able to translate meals to a time range.

Tested on https://duckling.wit.ai/

l5t commented 8 years ago

Good idea. We can probably add it but one would argue that the time ranges for meal really depends on your country/culture so this is probably something that can be handled via a custom entity to detect the meal type, and then mapped to the specific time range for your app

magnusburton commented 8 years ago

@l5t I agree with @alvinthen tat we should add in breakfast and dinner time ranges. I did a quick search what it came up with was that most countries tend to eat dinner in the 5.30pm to 9.00pm range. A range for that period of time wouldn't hurt right? Compared to not returning anything at all.