facebookarchive / exerslide

A framework to create React-based HTML presentations and tutorials.
https://facebookincubator.github.io/exerslide/
Other
437 stars 46 forks source link

Problems with Windows paths #12

Closed rubengees closed 8 years ago

rubengees commented 8 years ago

Node version: 4.6.0 Exerslide version: 1.1.2

We recently started a new presentation with exerslide and stumbled upon this exception when running exerslide serve on windows:

Change detected, updating presentation...
Presentation generation failed!
List of errors:

In file "11699-6744-1vf30ii\slides.js":
  SyntaxError: C:/Users/geesr/fh/Exerslide/presentation/11699-6744-1vf30ii/slides.js: Octal literal in strict mode (3:99)

    1 | module.exports = [
    2 | require("C:\Users\geesr\fh\Exerslide\presentation\node_modules\exerslide\lib\slide-loader!..\slides\00-Electron\00-Übersicht.md"),
  > 3 | require("C:\Users\geesr\fh\Exerslide\presentation\node_modules\exerslide\lib\slide-loader!..\slides\01-AngularJS\00-Übersicht.md"),
      |                                                                                                    ^
    4 | require("C:\Users\geesr\fh\Exerslide\presentation\node_modules\exerslide\lib\slide-loader!..\slides\02-Elm\00-Übersicht.md"),
    5 | require("C:\Users\geesr\fh\Exerslide\presentation\node_modules\exerslide\lib\slide-loader!..\slides\03-GraphQL\00-Übersicht.md"),
    6 | require("C:\Users\geesr\fh\Exerslide\presentation\node_modules\exerslide\lib\slide-loader!..\slides\04-Polymer\00-Übersicht.md"),

As you can see, this error appears in the generated slides.js file, due to parts of the paths getting interpreted as an octal literal. We followed your recommendation in the README to name the folders like this, so this should be supported...

If you want to see yourself, our project is located here.

This works fine on Linux and MacOS as no \ is used there. Please have a look. Thanks in advance!