facebookarchive / extension-example

Basic dynamically loadable extension for HHVM
30 stars 13 forks source link

building broken with hhvm 3.7 #12

Closed shish closed 8 years ago

shish commented 9 years ago
$ ./build.sh
** hphpize complete, now run `cmake . && make` to build, `make test` to test
-- Configuring for HHVM API version 20150212
CMake Warning (dev) at CMakeLists.txt:42 (add_custom_target):
  Policy CMP0037 is not set: Target names should not be reserved and should
  match a validity pattern.  Run "cmake --help-policy CMP0037" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  The target name "test" is reserved or not valid for certain CMake features,
  such as generator expressions, and may result in undefined behavior.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring done
-- Generating done
-- Build files have been written to: /home/shish/extension-example
[100%] Building CXX object CMakeFiles/example.dir/example.cpp.o
/home/shish/extension-example/example.cpp:17:45: fatal error: hphp/runtime/base/base-includes.h: No such file or directory
 #include "hphp/runtime/base/base-includes.h"
                                             ^
compilation terminated.
CMakeFiles/example.dir/build.make:54: recipe for target 'CMakeFiles/example.dir/example.cpp.o' failed
make[2]: *** [CMakeFiles/example.dir/example.cpp.o] Error 1
CMakeFiles/Makefile2:60: recipe for target 'CMakeFiles/example.dir/all' failed
make[1]: *** [CMakeFiles/example.dir/all] Error 2
Makefile:117: recipe for target 'all' failed
make: *** [all] Error 2
JoelMarcey commented 8 years ago

Fixed by: cf4091a322bc0dcbd360e985c75310e67cd5fc73