Use POSIX shell script syntax for portability

facebookarchive / extension-example

Basic dynamically loadable extension for HHVM

30 stars 13 forks source link

Use POSIX shell script syntax for portability #3

Closed jmikola closed 8 years ago

jmikola commented 10 years ago

Ubuntu happens to use Dash as its shell, which lacks some Bash syntax found in most shells. The [[ conditional syntax would throw an error. The POSIX-compatible syntax is [ and a = equality test instead of ==. Additional info: https://wiki.ubuntu.com/DashAsBinSh

jmikola commented 8 years ago

Looks like the change in this PR was already implemented in https://github.com/hhvm/extension-example/commit/8a40c432a7b7871e35fae41b7ef285dcf8b02ecc. :+1: