search

facebookarchive / facebook-clang-plugins

Plugins to clang-analyzer and clang-frontend
MIT License
482 stars 85 forks source link

Add storageClass for variable declarations #5

Closed vsilyaev closed 6 years ago

vsilyaev commented 6 years ago

This is part of facebook/infer#801, it adds optional storageClass to variableDeclarations, it's used to differentiate scope of global variables (file/static versus global), and it follows the precedent in function declarations.

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

dulmarod commented 6 years ago

make -C libtooling test is failing, @vsilyaev you need to re-record the tests.

dulmarod commented 6 years ago

For more info on tests, see https://github.com/facebook/facebook-clang-plugins/blob/master/CONTRIBUTING.md#pull-requests.

vsilyaev commented 6 years ago

@dulmarod , tests are now updated. however I am not sure what to do with "(non-Darwin architecture detected)" tests , since if test results are affected, I will not be able to update them.

dulmarod commented 6 years ago

Looks good now, we care mostly about the libtooling tests. They are passing now.