search

facebookarchive / facebook-for-magento

A first-party extension plugin built for Magento. This plugin will install a pixel on your site, upload your products into a catalog for use in FB ads, and (optionally) auto-create an FB shop with your products.
https://www.facebook.com/business/help/532749253576163
84 stars 57 forks source link

Price Tax Problem #100

Open kaipiyann opened 5 years ago

kaipiyann commented 5 years ago

There is a problem with price tax. The result is that I got price with double tax...cause the module add tax to a price including price....

The problem is in getFinalPrice method. You should make something like that :

$priceIncludesTax = Mage::getStoreConfig(Mage_Tax_Model_Config::CONFIG_XML_PATH_PRICE_INCLUDES_TAX, Mage::app()->getStore(FacebookAdsToolbox::getDefaultStoreId()));

return $this->taxHelper->getPrice(
        $product, $price, true, null, null, null, null, $priceIncludesTax, false);
dmitridr commented 5 years ago

Hi,

Thanks for reporting this. Please consider sending us a pull request with this code so that we can give you full credit. If not, we will eventually address it.