search

facebookarchive / facebook-for-magento

A first-party extension plugin built for Magento. This plugin will install a pixel on your site, upload your products into a catalog for use in FB ads, and (optionally) auto-create an FB shop with your products.
https://www.facebook.com/business/help/532749253576163
84 stars 57 forks source link

Correct 2x invalid trailing commas in JS functions params #14

Closed kimsondrup closed 6 years ago

kimsondrup commented 6 years ago

Correct invalid syntax in js/Facebook/AdsExtension/Adminhtml/fae.js

dmitridr commented 6 years ago

Hello!

Trailing commas appear legal since ES 2017, but after a discussion with the team we're okay with merging this.

Thanks for the contribution! We'd love to see more contributions from you in the future: please take a look at our issues marked with help-wanted if you're interested.

~Dmitri