search

facebookarchive / facebook-for-magento

A first-party extension plugin built for Magento. This plugin will install a pixel on your site, upload your products into a catalog for use in FB ads, and (optionally) auto-create an FB shop with your products.
https://www.facebook.com/business/help/532749253576163
84 stars 57 forks source link

Solving compatible method declaration #80

Closed andrewdaluz closed 6 years ago

andrewdaluz commented 6 years ago

After installing the module it gives the error that method buildProductEntry($product, $product_name) is not compatible with parent method buildProductEntry($product, $product_name, $stock = null)

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

dmitridr commented 6 years ago

Hi @andrewdaluz, thanks for the pull request! I'm guessing you are using master to test?

Unfortunately we can't accept it. We caught this same bug yesterday as well and we already fixed it in a different way by removing stock entirely : Here's the fix which landed just now.

If you update to master the bug should be gone. But I recommend using the v2.5.0 release until we release a new version, which will be today or tomorrow.