Crashing on Window change of app .

dipkasyap commented 5 years ago

Checklist

[x] I've updated to the latest released version of the SDK
[x] I've searched for existing GitHub issues
[x] I've looked for existing answers on Stack Overflow and the Facebook Developers Group
[x] I've read the Code of Conduct
[x] This issue is not security related and can safely be disclosed publicly on GitHub

Environment

Describe your dev environment here, giving as many details as possible. If you have them, make sure to include:

Xcode Version: 10.3 (10G8)
Swift Version: 4.2
Installation Platform & Verison: [Cocoapods|Carthage|Manual] version 1.6.0

Goals

What do you want to achieve? Crash free execution.

Expected Results

What do you expect to happen? No Crash

Actual Results

Crashing

What actually happened? Can you provide a stack trace? When i change the window of app, it crashes the app.

Steps to Reproduce

Change app window root controller.

Update

Seems facebook SDK is trying to access deallocated object via method swizzling

dreamolight commented 5 years ago

Hi @dipkasyap , do you mind sharing your Facebook App ID?

dipkasyap commented 5 years ago

727258441036240 is my app id.

dipkasyap commented 5 years ago

@dreamolight I have added a screenshot from my stack trace. Could you please update me on this

dreamolight commented 5 years ago

I've disabled the module for your app, the code won't be executed before we figured the root cause.

dipkasyap commented 5 years ago

if it helps Complete Stack trace of the crash

# URL: https://fabric.io/myAppName2/ios/apps/com.myAppName.app/issues/ed1395638d0f173e4965f7ac5632dd73/sessions/latest
# Organization: myAppName
# Platform: ios
# Application: myAppName
# Version: 2.0.4 (369)
# Bundle Identifier: com.myAppName.app
# Issue ID: ed1395638d0f173e4965f7ac5632dd73
# Session ID: c6a5eed720d54775be1df92e1c19406b_DNE_0_v2
# Date: 2019-08-26T00:31:00Z
# OS Version: 12.4.0 (16G77)
# Device: iPhone 7 Plus
# RAM Free: 4.3%
# Disk Free: 62%

#0. Crashed: com.apple.main-thread
0  libobjc.A.dylib                0x1a5fcb530 objc_msgSend + 16
1  FBSDKCoreKit                   0x102aa7af4 __47-[FBSDKEventBindingManager mat`chView:delegate:]_block_invoke + 279 (FBSDKEventBindingManager.m:279)
2  libdispatch.dylib              0x1a6818a38 _dispatch_call_block_and_release + 24
3  libdispatch.dylib              0x1a68197d4 _dispatch_client_callout + 16
4  libdispatch.dylib              0x1a67c7008 _dispatch_main_queue_callback_4CF$VARIANT$mp + 1068
5  CoreFoundation                 0x1a6d6c32c __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
6  CoreFoundation                 0x1a6d67264 __CFRunLoopRun + 1924
7  CoreFoundation                 0x1a6d667c0 CFRunLoopRunSpecific + 436
8  GraphicsServices               0x1a8f6779c GSEventRunModal + 104
9  UIKitCore                      0x1d3865c38 UIApplicationMain + 212
10 myAppName                          0x1021709f0 main + 20 (HeroTargetState.swift:20)
11 libdyld.dylib                  0x1a682a8e0 start + 4

--

#0. Crashed: com.apple.main-thread
0  libobjc.A.dylib                0x1a5fcb530 objc_msgSend + 16
1  FBSDKCoreKit                   0x102aa7af4 __47-[FBSDKEventBindingManager matchView:delegate:]_block_invoke + 279 (FBSDKEventBindingManager.m:279)
2  libdispatch.dylib              0x1a6818a38 _dispatch_call_block_and_release + 24
3  libdispatch.dylib              0x1a68197d4 _dispatch_client_callout + 16
4  libdispatch.dylib              0x1a67c7008 _dispatch_main_queue_callback_4CF$VARIANT$mp + 1068
5  CoreFoundation                 0x1a6d6c32c __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
6  CoreFoundation                 0x1a6d67264 __CFRunLoopRun + 1924
7  CoreFoundation                 0x1a6d667c0 CFRunLoopRunSpecific + 436
8  GraphicsServices               0x1a8f6779c GSEventRunModal + 104
9  UIKitCore                      0x1d3865c38 UIApplicationMain + 212
10 myAppName                          0x1021709f0 main + 20 (HeroTargetState.swift:20)
11 libdyld.dylib                  0x1a682a8e0 start + 4

#1. com.apple.uikit.eventfetch-thread
0  libsystem_kernel.dylib         0x1a696c0f4 mach_msg_trap + 8
1  libsystem_kernel.dylib         0x1a696b5a0 mach_msg + 72
2  CoreFoundation                 0x1a6d6c120 __CFRunLoopServiceMachPort + 236
3  CoreFoundation                 0x1a6d67030 __CFRunLoopRun + 1360
4  CoreFoundation                 0x1a6d667c0 CFRunLoopRunSpecific + 436
5  Foundation                     0x1a7734eac -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 300
6  Foundation                     0x1a7734d3c -[NSRunLoop(NSRunLoop) runUntilDate:] + 96
7  UIKitCore                      0x1d394b754 -[UIEventFetcher threadMain] + 136
8  Foundation                     0x1a7861674 __NSThread__start__ + 984
9  libsystem_pthread.dylib        0x1a69f92c0 _pthread_body + 128
10 libsystem_pthread.dylib        0x1a69f9220 _pthread_start + 44
11 libsystem_pthread.dylib        0x1a69fccdc thread_start + 4

#2. com.twitter.crashlytics.ios.MachExceptionServer
0  myAppName                          0x10239ab1c CLSProcessRecordAllThreads + 376 (CLSProcess.c:376)
1  myAppName                          0x10239af04 CLSProcessRecordAllThreads + 407 (CLSProcess.c:407)
2  myAppName                          0x10238a888 CLSHandler + 26 (CLSHandler.m:26)
3  myAppName                          0x102385c78 CLSMachExceptionServer + 446 (CLSMachException.c:446)
4  libsystem_pthread.dylib        0x1a69f92c0 _pthread_body + 128
5  libsystem_pthread.dylib        0x1a69f9220 _pthread_start + 44
6  libsystem_pthread.dylib        0x1a69fccdc thread_start + 4

#3. com.apple.NSURLConnectionLoader
0  libsystem_kernel.dylib         0x1a696c0f4 mach_msg_trap + 8
1  libsystem_kernel.dylib         0x1a696b5a0 mach_msg + 72
2  CoreFoundation                 0x1a6d6c120 __CFRunLoopServiceMachPort + 236
3  CoreFoundation                 0x1a6d67030 __CFRunLoopRun + 1360
4  CoreFoundation                 0x1a6d667c0 CFRunLoopRunSpecific + 436
5  CFNetwork                      0x1a738074c -[__CoreSchedulingSetRunnable runForever] + 216
6  Foundation                     0x1a7861674 __NSThread__start__ + 984
7  libsystem_pthread.dylib        0x1a69f92c0 _pthread_body + 128
8  libsystem_pthread.dylib        0x1a69f9220 _pthread_start + 44
9  libsystem_pthread.dylib        0x1a69fccdc thread_start + 4

#4. com.apple.CoreMotion.MotionThread
0  libsystem_kernel.dylib         0x1a696c0f4 mach_msg_trap + 8
1  libsystem_kernel.dylib         0x1a696b5a0 mach_msg + 72
2  CoreFoundation                 0x1a6d6c120 __CFRunLoopServiceMachPort + 236
3  CoreFoundation                 0x1a6d67030 __CFRunLoopRun + 1360
4  CoreFoundation                 0x1a6d667c0 CFRunLoopRunSpecific + 436
5  CoreFoundation                 0x1a6d6751c CFRunLoopRun + 80
6  CoreMotion                     0x1ac73dbe8 (Missing)
7  libsystem_pthread.dylib        0x1a69f92c0 _pthread_body + 128
8  libsystem_pthread.dylib        0x1a69f9220 _pthread_start + 44
9  libsystem_pthread.dylib        0x1a69fccdc thread_start + 4

#5. AVAudioSession Notify Thread
0  libsystem_kernel.dylib         0x1a696c0f4 mach_msg_trap + 8
1  libsystem_kernel.dylib         0x1a696b5a0 mach_msg + 72
2  CoreFoundation                 0x1a6d6c120 __CFRunLoopServiceMachPort + 236
3  CoreFoundation                 0x1a6d67030 __CFRunLoopRun + 1360
4  CoreFoundation                 0x1a6d667c0 CFRunLoopRunSpecific + 436
5  AVFAudio                       0x1accd8334 GenericRunLoopThread::Entry(void*) + 156
6  AVFAudio                       0x1acd02c60 CAPThread::Entry(CAPThread*) + 88
7  libsystem_pthread.dylib        0x1a69f92c0 _pthread_body + 128
8  libsystem_pthread.dylib        0x1a69f9220 _pthread_start + 44
9  libsystem_pthread.dylib        0x1a69fccdc thread_start + 4

#6. Realm notification listener
0  libsystem_kernel.dylib         0x1a69788f4 kevent + 8
1  Realm                          0x102ce2130 realm::_impl::ExternalCommitHelper::listen() + 217 (external_commit_helper.cpp:217)
2  Realm                          0x102ce2c60 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, realm::_impl::ExternalCommitHelper::ExternalCommitHelper(realm::_impl::RealmCoordinator&)::$_0> >(void*) + 170 (tuple:170)
3  libsystem_pthread.dylib        0x1a69f92c0 _pthread_body + 128
4  libsystem_pthread.dylib        0x1a69f9220 _pthread_start + 44
5  libsystem_pthread.dylib        0x1a69fccdc thread_start + 4

#7. com.apple.scenekit.scnview-renderer
0  libsystem_kernel.dylib         0x1a696c0f4 mach_msg_trap + 8
1  libsystem_kernel.dylib         0x1a696b5a0 mach_msg + 72
2  CoreFoundation                 0x1a6d6c120 __CFRunLoopServiceMachPort + 236
3  CoreFoundation                 0x1a6d67030 __CFRunLoopRun + 1360
4  CoreFoundation                 0x1a6d667c0 CFRunLoopRunSpecific + 436
5  Foundation                     0x1a7734eac -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 300
6  SceneKit                       0x1babdd09c __49-[SCNView(SCNDisplayLink) _initializeDisplayLink]_block_invoke + 428
7  SceneKit                       0x1babdd1f4 __SCNRenderThread_start__ + 96
8  libsystem_pthread.dylib        0x1a69f92c0 _pthread_body + 128
9  libsystem_pthread.dylib        0x1a69f9220 _pthread_start + 44
10 libsystem_pthread.dylib        0x1a69fccdc thread_start + 4

#8. com.apple.scenekit.scnview-renderer
0  libsystem_kernel.dylib         0x1a696c0f4 mach_msg_trap + 8
1  libsystem_kernel.dylib         0x1a696b5a0 mach_msg + 72
2  CoreFoundation                 0x1a6d6c120 __CFRunLoopServiceMachPort + 236
3  CoreFoundation                 0x1a6d67030 __CFRunLoopRun + 1360
4  CoreFoundation                 0x1a6d667c0 CFRunLoopRunSpecific + 436
5  Foundation                     0x1a7734eac -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 300
6  SceneKit                       0x1babdd09c __49-[SCNView(SCNDisplayLink) _initializeDisplayLink]_block_invoke + 428
7  SceneKit                       0x1babdd1f4 __SCNRenderThread_start__ + 96
8  libsystem_pthread.dylib        0x1a69f92c0 _pthread_body + 128
9  libsystem_pthread.dylib        0x1a69f9220 _pthread_start + 44
10 libsystem_pthread.dylib        0x1a69fccdc thread_start + 4

#9. com.apple.scenekit.scnview-renderer
0  libsystem_kernel.dylib         0x1a696c0f4 mach_msg_trap + 8
1  libsystem_kernel.dylib         0x1a696b5a0 mach_msg + 72
2  CoreFoundation                 0x1a6d6c120 __CFRunLoopServiceMachPort + 236
3  CoreFoundation                 0x1a6d67030 __CFRunLoopRun + 1360
4  CoreFoundation                 0x1a6d667c0 CFRunLoopRunSpecific + 436
5  Foundation                     0x1a7734eac -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 300
6  SceneKit                       0x1babdd09c __49-[SCNView(SCNDisplayLink) _initializeDisplayLink]_block_invoke + 428
7  SceneKit                       0x1babdd1f4 __SCNRenderThread_start__ + 96
8  libsystem_pthread.dylib        0x1a69f92c0 _pthread_body + 128
9  libsystem_pthread.dylib        0x1a69f9220 _pthread_start + 44
10 libsystem_pthread.dylib        0x1a69fccdc thread_start + 4

#10. Thread
0  libsystem_kernel.dylib         0x1a6977b74 __workq_kernreturn + 8
1  libsystem_pthread.dylib        0x1a69fa138 _pthread_wqthread + 340
2  libsystem_pthread.dylib        0x1a69fccd4 start_wqthread + 4

#11. Thread
0  libsystem_kernel.dylib         0x1a6977b74 __workq_kernreturn + 8
1  libsystem_pthread.dylib        0x1a69fa138 _pthread_wqthread + 340
2  libsystem_pthread.dylib        0x1a69fccd4 start_wqthread + 4

#12. Thread
0  libsystem_pthread.dylib        0x1a69fccd0 start_wqthread + 190

#13. Thread
0  libsystem_kernel.dylib         0x1a6977b74 __workq_kernreturn + 8
1  libsystem_pthread.dylib        0x1a69fa1f8 _pthread_wqthread + 532
2  libsystem_pthread.dylib        0x1a69fccd4 start_wqthread + 4

#14. Thread
0  libsystem_kernel.dylib         0x1a6977b74 __workq_kernreturn + 8
1  libsystem_pthread.dylib        0x1a69fa1f8 _pthread_wqthread + 532
2  libsystem_pthread.dylib        0x1a69fccd4 start_wqthread + 4

#15. Thread
0  libsystem_kernel.dylib         0x1a6977b74 __workq_kernreturn + 8
1  libsystem_pthread.dylib        0x1a69fa138 _pthread_wqthread + 340
2  libsystem_pthread.dylib        0x1a69fccd4 start_wqthread + 4

dipkasyap commented 5 years ago

@dreamolight Any update on this issue?

dreamolight commented 5 years ago

Hi @dipkasyap , we weren't able to reproduce the issue at our side, the bundle id in the logs looks like it's for a sample project, do you mind sharing the sample project (if it is) so we can debug? We've disabled codeless for your app so the code won't be executed in case you're concerned about the issue.

dipkasyap commented 5 years ago

Hi @dreamolight Thank you for the effort, but I am pretty sure it's the null pointer exception, on swizzling, could you please add another method swizzling along with facebook library and test it, FYI it is trying to set delegate of UITableViuew on the swizzled method.

dipkasyap commented 5 years ago

@dreamolight Is anything on progress ? Could you please re enable the module ?

dreamolight commented 5 years ago

We've identified the root cause, will fix in next release and the module will be turned on for apps with SDK versions that has the fix.

dreamolight commented 5 years ago

Closing this as fix has been shipped in latest release

joesus commented 5 years ago

Clarification, the latest release on the facebook-ios-sdk repository. This repository is no longer receiving updates. Please see the migration guide that's linked in the README for information on how to move over to the other repo.

facebookarchive / facebook-swift-sdk