search

facebookarchive / facebook-swift-sdk

Integrate your iOS apps in Swift with Facebook Platform.
https://developers.facebook.com/docs/swift
Other
1.51k stars 336 forks source link

Bug: ITMS-90809: Deprecated API Usage - UIWebView #519

Closed joacim-dico closed 5 years ago

joacim-dico commented 5 years ago

Checklist

Environment

Goals

Replace all occurences of UIWebView so I can continue using facebook tracking for my app.

Expected Results

The app is uploaded without any issues.

Actual Results

When I upload the app, I receive an email from apple that says this:

We identified one or more issues with a recent delivery for your app, APP_NAME. Your delivery was successful, but you may wish to correct the following issues in your next delivery:

ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs . See https://developer.apple.com/documentation/uikit/uiwebview for more information.

After you’ve corrected the issues, you can use Xcode or Application Loader to upload a new binary to App Store Connect.

Steps to Reproduce

Upload an IPA file to testflight or to app store

davidrothera commented 5 years ago

This comes from the upstream dependency on the ObjC API, this should be fixed as of a couple of days ago in https://github.com/facebook/facebook-objc-sdk/commit/fa3f224b819171adbe70c23799c86882abefbf9d but there hasn't yet been a release of that API but hang on and there should be one soon.

davidrothera commented 5 years ago

Just checking as well, this should just be a warning at this point or is it blocking your builds completely?

joacim-dico commented 5 years ago

Just checking as well, this should just be a warning at this point or is it blocking your builds completely?

It's a warning at the moment. I guess they will block the builds completely when iOS 13 is released.

joesus commented 5 years ago

True story. We will release a new version of the Swift SDK when we release that fix in the ObjC SDK. The goal going forward is to have side-by-side releases. (Technically because of how we're managing dependencies you can get the fix by reinstalling dependencies as soon as ObjC is released but it is clearer if the fix is represented by a corresponding version bump with Swift).

Samrat555 commented 5 years ago

I have got the same issue from AppStore. Please fix this as soon as possible.

krishnaSoni2113 commented 5 years ago

Hello Team I have also got this issue from AppStore. Looking forward an updated from your side as soon as possible.

ubersexual commented 5 years ago

Hi Team I have got this issue too. Please fix this as soon as possible.

peterkuch commented 5 years ago

Hi Best Team

I got that issue too. when i try to upload to AppStore for test-flight that ok, but have to fix when i published for AppStore Review. Thanks hope we got good new from facebook soon.

joesus commented 5 years ago

Please use v0.9.0. It has the updated web view code. Please reopen if this does not work for some reason.

peterkuch commented 5 years ago

On Wed, Sep 4, 2019 at 5:13 PM An Nguyen notifications@github.com wrote:

Hello @joesus https://github.com/joesus , Where can I get this version? I can't fint it when try to install by CocoaPods. Thank you so much.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/facebook/facebook-swift-sdk/issues/519?email_source=notifications&email_token=ADLUIMWSSLZ4GNWNCNEEKKDQH6C4JA5CNFSM4ISBU5RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD53CSHA#issuecomment-527837468, or mute the thread https://github.com/notifications/unsubscribe-auth/ADLUIMQ4AUOQQO5L3NOXT7TQH6C4JANCNFSM4ISBU5RA .

peterkuch commented 5 years ago

also if can't please remove Podfile.lock after