facebookarchive / fb-adb

A better shell for Android devices
Other
1.14k stars 128 forks source link

Some su implementations require -c before command #32

Open BurntBrunch opened 9 years ago

BurntBrunch commented 9 years ago

Cyanogen running on m7:

: fb-adb shell -r fb-adb shell: trouble re-execing adb stub as root: Unknown id: stub

shell@m7:/ $ su whoami Unknown id: whoami 1|shell@m7:/ $ su -c whoami root

jbeich commented 8 years ago

Can you reproduce after b230619?

genevera commented 7 years ago

I get this off of master:

$  fb-adb -r shell echo 'hello'
fb-adb shell: trouble re-execing adb stub as root: fb-adb stub: execvpe("su"): Invalid argument
$  fb-adb -r shell
fb-adb shell: trouble re-execing adb stub as root: fb-adb stub: execvpe("su"): Invalid argument
genevera commented 7 years ago

I restored the function from https://github.com/facebook/fb-adb/blob/1.4.4/cmd_stub.c and it seems to be working for both shell and ctar

ping @BurntBrunch @jbeich