search

facebookarchive / fb-adb

A better shell for Android devices
Other
1.14k stars 128 forks source link

r10c ptsname Compile Error #8

Closed niedzielski closed 9 years ago

niedzielski commented 10 years ago

When performing a standard build, the following error occurs:

...
...
...
mv -f .deps/chat.Tpo .deps/chat.Po
i686-linux-android-gcc -std=gnu99 -DPACKAGE_NAME=\"fb-adb\" -DPACKAGE_TARNAME=\"fb-adb\" -DPACKAGE_VERSION=\"1.0\" -DPACKAGE_STRING=\"fb-adb\ 1.0\" -DPACKAGE_BUGREPORT=\"dancol@fb.com\" -DPACKAGE_URL=\"\" -DPACKAGE=\"fb-adb\" -DVERSION=\"1.0\" -DHAVE_PPOLL=1 -DHAVE_DUP3=1 -DHAVE_PIPE2=1 -DHAVE_PTSNAME=1 -I. -I../../stub-x86/..  -I. -Wall -Werror -D_GNU_SOURCE=1 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -DBUILD_STUB=1 -DNDEBUG=1 -flto  -g -O2 -Wno-format -MT child.o -MD -MP -MF .deps/child.Tpo -c -o child.o ../../stub-x86/../child.c
../../stub-x86/../child.c: In function 'child_start':
../../stub-x86/../child.c:121:47: error: call to 'ptsname' declared with attribute warning: ptsname is not thread-safe; use ptsname_r instead [-Werror]
cc1: all warnings being treated as errors

This is a new issue on Mac using the r10c NDK. It worked fine on r10b.

seguri commented 9 years ago

Still the same as of r10d

evandrix commented 9 years ago

Just removed all occurrences of -Werror in /configure.ac for now. Apparently the thread-safe variant of the function ptsnames_r doesn't exist on OSX.

dcolascione commented 9 years ago

I removed -Werror from the configure scripts. (The -Werror passed to AM_INIT_AUTOMAKE controls a different feature.)