facebookarchive / fbctf

Platform to host Capture the Flag competitions
Other
6.52k stars 1.32k forks source link

A translation file BUG #661

Open NS-Sp4ce opened 5 years ago

NS-Sp4ce commented 5 years ago

https://github.com/facebook/fbctf/blob/4ec9b6be404fce1bed6d1066fccf10c4255767bb/src/controllers/AdminController.php#L3792

This kind of writing will cause the translation file to be invalid.

status_<span class="highlighted">{tr('OK')}</span>

Should be changed as follows.

{tr('status_')}<span class="highlighted">{tr('OK')}</span>

https://github.com/facebook/fbctf/blob/4ec9b6be404fce1bed6d1066fccf10c4255767bb/src/controllers/IndexController.php#L384 and https://github.com/facebook/fbctf/blob/4ec9b6be404fce1bed6d1066fccf10c4255767bb/src/controllers/IndexController.php#L598

<h1 class="fb-glitch" data-text="Team Registration">

Should be changed as follows.

<h1 class="fb-glitch" data-text={tr('Team Registration')}>