search

facebookarchive / fixed-data-table

A React table component designed to allow presenting thousands of rows of data.
http://facebook.github.io/fixed-data-table/
Other
4.3k stars 553 forks source link

Don't pass columnKey prop to div element #426

Closed Dilatorily closed 8 years ago

Dilatorily commented 8 years ago

See: https://facebook.github.io/react/warnings/unknown-prop.html

Fixes #420

ghost commented 8 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

KamranAsif commented 8 years ago

Hey,

We have this fix in our repo: https://github.com/schrodinger/fixed-data-table-2/pull/28 I haven't seen much support for this repo so we've went ahead and created a maintained fork. Feel free to check it out

ghost commented 8 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

zpao commented 8 years ago

Thanks!

zpao commented 8 years ago

Just shipped 0.6.2 with this.