search

facebookarchive / fixed-data-table

A React table component designed to allow presenting thousands of rows of data.
http://facebook.github.io/fixed-data-table/
Other
4.3k stars 553 forks source link

Stop checking in dist/ #427

Open zpao opened 8 years ago

zpao commented 8 years ago

I'm pretty sure we don't even support Bower so there's no good reason to check in dist builds. dist/ will get built as part of the release process and that's it.

Daniel15 commented 8 years ago

If we do want to support Bower, we could have a separate repo with just the dist files. That's what I do with Babel-standalone.

It is definitely still useful to have built files available (eg. for people that don't use npm), they shouldn't be checked in though. Instead, we should use the "releases" feature of Github for this purpose.

zpao commented 8 years ago

We've been doing it for React forever too. But I don't like it (mostly because the value proposition isn't really there). We should continue shipping dist/ to npm and then we can use something like npmcdn, which can even serve a zip file for bower. We could also set up cdnjs/jsdelivr to pull those files whenever we publish to npm.

Edit: And yes we can use the releases feature too. That's also marginally useful so personally I'm pretty meh about that.

Daniel15 commented 8 years ago

We could also set up cdnjs/jsdelivr to pull those files whenever we publish to npm.

I set up CDNJS to do this for babel-standalone, it works pretty well.

We've been doing it for React forever too

React hasn't included dist in its repo for a while though, right? The files for Bower are in a separate repo (https://github.com/reactjs/react-bower).

zpao commented 8 years ago

The files for Bower are in a separate repo

Oh yea, that's what I meant. I didn't quote you but I was responding to that proposal :)

Daniel15 commented 8 years ago

Oh cool, now I understand! If Bower can use npmcdn, then I think that's probably the best approach as it means no extra work for us :smile: Bower seems to be slowly dying anyways, so it's probably not worth having something special just for Bower.