search

facebookarchive / fixed-data-table

A React table component designed to allow presenting thousands of rows of data.
http://facebook.github.io/fixed-data-table/
Other
4.3k stars 553 forks source link

scrollToRow doesn't work on brand-new tables #458

Open jacobbaskin opened 7 years ago

jacobbaskin commented 7 years ago

FixedDataTable's componentWillReceiveProps sets this._rowToScrollTo and then calls this._calculateState. This scrolls to the desired row on update.

However, when creating a new table, this._rowToScrollTo is set in componentWillMount, which is called after getInitialState (which calls this._calculateState). As a result, the row never gets scrolled to.

The same is also true for scrollToColumn probably but I haven't tested.

txgruppi commented 7 years ago

What is missing for the changes to be accepted?

I need scrollToRow to work on a new table.

Cheers.

wcjordan commented 7 years ago

Hey @txgruppi, this repo is no longer maintained, but we have a maintained fork at schrodinger/fixed-data-table-2. Could you try that and see if this is still an issue?

txgruppi commented 7 years ago

@wcjordan I will check this one.

Someone, who is allowed to edit this repo's files, could add a message on README.md to inform this repo is no longer maintained. =/

Cheers.

wcjordan commented 7 years ago

Ya it could be much more clear, but no actions been taken yet. Feel free to upvote or chime in on #468 and #408 where discussion about that has been focused.