search

facebookarchive / fixed-data-table

A React table component designed to allow presenting thousands of rows of data.
http://facebook.github.io/fixed-data-table/
Other
4.3k stars 553 forks source link

Move contents of getInitialState into componentWillMount. #459

Closed jacobbaskin closed 6 years ago

jacobbaskin commented 7 years ago

This allows calculateState to handle scrollToRow correctly on initial render. Fixes #458.

ghost commented 7 years ago

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

KamranAsif commented 7 years ago

Cool fix. Facebook hasn't really been maintain this repo but some of us have been working on a fork with bug fixes, release, unit test, documentation, etc. https://github.com/schrodinger/fixed-data-table-2

Would you mind doing a PR on there as well?

jacobbaskin commented 7 years ago

Done.

zpao commented 6 years ago

Thanks for your pull request. I apologize for leaving this project in limbo and not addressing your concerns. I have archived this project after doing a final release to make it compatible with React v16.