Migrating from React.PropTypes

[Odrin]

Fix React deprecation warning.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[travi]

@gaearon anything you can do to nudge this internally? this is the last package preventing the react 15.5 upgrade on a few projects for my team

[gaearon]

Sure thing.

[travi]

Great, thanks!

[gaearon]

@kyldvs will review this soon.

[kyldvs]

I think this is okay - really I have no idea how this repo works though :)

[gaearon]

Can you get a patch release out?

[wcjordan]

Hey @kyldvs & @gaearon, I'm one of the maintainers of the fixed-data-table-2 fork. You should be able to create a release with npm run publish-package. We ran into some issues because react-docgen doesn't support create-react-class yet, but I'm working on a PR for that.

While you're active here, would it be possible to revisit adding a deprecation notice to the repo that points users to fixed-data-table-2 and react-virtualized? It's been discussed for a while, but the repo's been left in limbo (#468 & #408).

P.S. Thanks for all your hard work on React & Redux. It's made my life incredibly better both in working on web applications and in mentoring and training others. The effort you put into documentation & tooling means everything.

[tkirda]

I don't see why it should be marked as deprecated. Usage shows more than 50K downloads per month. More than double over fixed-data-table-2. It is stable and works well (at least for us). Maybe there are cases where it is not sufficient and then you can freely choose to use other packages.

And with new version of react that is coming out soon, I trust it will get necessary updates and we can continue using it. We use it on a project with a very large code base and switching to something else would be time consuming and risky. Deprecating would just be not fare to current user base.

These rants about deprecation is just noise and not really helping anyone.

[wcjordan]

The issue is that there have been 5 commits since November 2015 (8 if you include merge commits). Many users have filed issues and pull requests against the repo, and there are no active maintainers to address them.

[tkirda]

I know this is not ideal but that is reality. Low number of changes and popularity also shows that it is good enough.

[kyldvs]

@gaearon: Yes I asked @pieterv to publish a new version, should happen this morning. I don't actually have npm access for the project :)

Re: Deprecation/no active maintainers: We are aware and have been discussing it internally for a long time. Right now I do not have any updates related to that.

[wcjordan]

Thanks for the update, Kyle. Please let me know if there's anything we can do from the FDT2 end to help with the issues around maintenance.

[kyldvs]

Looks like it should be at 0.6.4 now, thanks @pieterv :)

https://www.npmjs.com/package/fixed-data-table

[pieterv]

let me know if i broke anything :D

[gaearon]

Thanks!

[travi]

thank you for getting this pushed through!

[travi]

could we get #488 pushed through too for the React.createClass warnings?