search

facebookarchive / fixed-data-table

A React table component designed to allow presenting thousands of rows of data.
http://facebook.github.io/fixed-data-table/
Other
4.3k stars 553 forks source link

The README Basic example does not work #493

Open glenne opened 7 years ago

glenne commented 7 years ago

The 'Basic' example on the main README.md page does not work. The first error is a reference to MyCustomCell which is not provided in the example. Removing use of MyCustomCell results in another error - _registerComponent(...): Target container is not a DOM element.

The Basic example should work without modification. This is especially important for those of us new to react and exploring what types of table components are available.

wcjordan commented 7 years ago

Hey @glenne, this repo's maintainers haven't been very active (see #468 and #408). I recommend checking out our fork at https://github.com/schrodinger/fixed-data-table-2 where we're trying to include any PRs and keep things up to date.

glenne commented 7 years ago

Great to see it being actively maintained in your fork! It looks like your Basic example has the same issues though that it doesn't work as-is. Should I perhaps create an issue in your fork?

wcjordan commented 7 years ago

Please do, and if you're willing feel free to create a pull request. I'm guessing that code has become out of date or assumes it's part of a page with a div with the id example. We tend to rely on the examples section of our docs a bit more.

Any details on how to make it easier to onboard to is much appreciated. Thanks!