search

facebookarchive / flow-language-server

An implementation of the Language Server Protocol for Flow
Other
188 stars 21 forks source link

Respond completionItem/resolve requests with received item #65

Closed ozanmakes closed 6 years ago

ozanmakes commented 6 years ago

We are declaring capabilities.completionProvider.resolveProvider = true, which makes some clients use the response from completionItem/resolve as the completion item.

Spec: https://microsoft.github.io/language-server-protocol/specification#completion-item-resolve-request-leftwards_arrow_with_hook

wbinnssmith commented 6 years ago

Thanks so much @osener -- this is awesome :D Can you sign the CLA and I'll merge promptly after.

ozanmakes commented 6 years ago

@wbinnssmith done!

wbinnssmith commented 6 years ago

thank you so much! 🙏