facebookarchive / flux

Application Architecture for Building User Interfaces
https://facebookarchive.github.io/flux/
Other
17.47k stars 3.46k forks source link

FluxContainer: Unsafe lifecycle methods were found within a strict-mode tree #452

Open satoshi-izawa opened 6 years ago

satoshi-izawa commented 6 years ago

FluxContainer contains componentWillReceiveProps. Does flux fix this problem?

tiarebalbi commented 6 years ago

I would say that this needs to be part of a big discussion as this problem can be fixed as part of a bigger change, adding support to React 16.4

screen shot 2018-05-25 at 5 44 12 pm
kyldvs commented 6 years ago

This will likely be addressed at some point within our version of FluxContainer at Facebook, but I do not know when that will be. At that time I can do a release with the appropriate changes, or if someone would like to contribute a PR sooner I'm happy to review!

tiarebalbi commented 6 years ago

I'm reviewing the changes that are going to be required once I have the items I will raise an early PR for a review! Thanks.