search

facebookarchive / flux

Application Architecture for Building User Interfaces
https://facebookarchive.github.io/flux/
Other
17.42k stars 3.47k forks source link

chore: upgrade fbjs #507

Closed dschaller closed 3 years ago

dschaller commented 3 years ago

Fixes #504

kyldvs commented 3 years ago

Awesome, thank you!

dschaller commented 3 years ago

@kyldvs thanks for merging :D

Is it possible to cut a release of flux with the upgraded dependency to pick this up in react-json-view and then in the docusaurus debug plugin?

Opened https://github.com/facebook/flux/pull/508 to make things easier :)

yangshun commented 3 years ago

@dschaller Sorry does the Docusaurus debug plugin use Flux? Which one are you referring to?

dschaller commented 3 years ago

@yangshun sorry about the confusion.

The dependency tree looks like: @docusaurus/plugin-debug -> react-json-view -> flux

When we publish a new version of flux, react-json-view can upgrade its dependency and publish a new version for plugin-debug to utilize.