Call super.UNSAFE_componentWillReceiveProps()

facebookarchive / flux

Application Architecture for Building User Interfaces

https://facebookarchive.github.io/flux/

Other

17.48k stars 3.46k forks source link

Call super.UNSAFE_componentWillReceiveProps() #533

Closed kemuridama closed 3 years ago

kemuridama commented 3 years ago

In React 17, we should use UNSAFE_coponentWillReceiveProps() instead of componentWillReceiveProps(). But a container component created by Container.create() overrides an original UNSAFE_componentWillReceiveProps() and does not call it.

This PR makes a container component calls both super.UNSAFE_componentWillReceiveProps() and super.componentWillReceiveProps() in lifecycle.

Please release patch version if this PR approved and merged.

yangshun commented 3 years ago

Thank you for the improvement!

kemuridama commented 3 years ago

@yangshun Thank you for your review and approval. Would you publish patch release, please?

him0 commented 3 years ago

The all users using a combination of facebook/flux and React v17 are looking for this patch release.

yangshun commented 3 years ago

Done - https://github.com/facebook/flux/releases/tag/4.0.2

kemuridama commented 3 years ago

Thanks!!