search

facebookarchive / gnlpy

A generic netlink library for python.
Other
161 stars 43 forks source link

Fixes #25 Install dependencies directly from requirements.txt in pip installation #26

Closed bhaveshAn closed 6 years ago

bhaveshAn commented 6 years ago

Fixes #25 Install dependencies directly from requirements.txt in pip installation

@vmauge Please review thanks

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

bhaveshAn commented 6 years ago

The requirements.txt can be removed from git (git rm requirements.txt), also, .travis.yml need to be updated to not run the pip install -r requirements.txt step.

done. https://github.com/bhaveshAn/gnlpy/tree/patch-1

chantra commented 6 years ago

Great stuff! Thanks @bhaveshAn