Use CACHE_DIR for composer packages

facebookarchive / heroku-buildpack-hhvm

Use HHVM on Heroku

66 stars 27 forks source link

Use CACHE_DIR for composer packages #17

Open henrikbjorn opened 10 years ago

henrikbjorn commented 10 years ago

Currently ALL packages are redownloaded on every build, this means it takes a lot longer to deploy simple changes. To overcome this it would be beneficial to use CACHE_DIR and cache dependencies before installing, also the composer binary could be cached there.

ClaudiuC commented 10 years ago

Yeah, I actually had a note to fix this and never got around to do it :+1:

Feel free to send a PR, I'll try to get to it later this week otherwise.

henrikbjorn commented 10 years ago

@ClaudiuC does the same contribution rules apply for this as for hhvm? Just saw the Contributor License Agreement etc.

ClaudiuC commented 10 years ago

I think you just need to fill that in once. I was under the impression you already did though. @ptarjan ?

ptarjan commented 10 years ago

We aren't going to need a CLA for this repository. I'll add a BSD licence file.

ClaudiuC commented 10 years ago

Oh great, thanks for the heads up!