search

facebookarchive / heroku-buildpack-hhvm

Use HHVM on Heroku
66 stars 27 forks source link

Support composer install #3

Closed riaf closed 11 years ago

riaf commented 11 years ago

I've added support Composer. However, I do not have experience using HHVM. Is this way right?

ptarjan commented 11 years ago

I like this, but would like @henrikbjorn to weigh in on the zip issue before I merge. Thanks for the PR.

henrikbjorn commented 11 years ago

I think that the only way to know for sure if unzip system command is available when installing with composer is to try it out.

ptarjan commented 11 years ago 
$ heroku run bash
Running `bash` attached to terminal... up, run.9523
~ $ unzip
bash: unzip: command not found
~ $
ptarjan commented 11 years ago

@henrikbjorn is there any harm to prefer-source?

henrikbjorn commented 11 years ago

@ptarjan only that it takes a lot more resources to clone for git, hg and you will get huge folders (as git contains everything).

henrikbjorn commented 11 years ago

Seems like that ZipExtension have landed in HHVM master, maybe this should be reopened and reevaluated.

ptarjan commented 11 years ago

@henrikbjorn we will have to wait for the next binary release and then we can try using zip in composer then

henrikbjorn commented 11 years ago

Is there a release cycle?

ptarjan commented 11 years ago

@henrikbjorn no formal time on the clock, but whenever a large change lands we will release a point release. One is coming in the next week for fastcgi.

nubs commented 10 years ago

It should be possible to remove --prefer-source now correct?

ptarjan commented 10 years ago

@nubs https://github.com/hhvm/heroku-buildpack-hhvm/commit/1da769bc26143a81182535f0f540ac71cf7ee48e try it out and open an issue if it doens't work for you