search

facebookarchive / hive-io-experimental

Hive I/O Library
Other
66 stars 30 forks source link

fix build error #58

Closed thinker0 closed 11 years ago

nitay commented 11 years ago

What is the build error without this?

thinker0 commented 11 years ago 
$ mvn clean package

[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/LogHelpers.java:[20,24] package org.apache.log4j does not exist
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/DataNucleusLogHelpers.java:[20,24] package org.apache.log4j does not exist
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/DataNucleusLogHelpers.java:[42,45] cannot find symbol
  symbol:   class Level
  location: class com.facebook.hiveio.log.DataNucleusLogHelpers
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/DataNucleusLogHelpers.java:[76,31] cannot find symbol
  symbol:   class Level
  location: class com.facebook.hiveio.log.DataNucleusLogHelpers
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/HiveLogHelpers.java:[26,24] package org.apache.log4j does not exist
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/HiveLogHelpers.java:[50,38] cannot find symbol
  symbol:   class Level
  location: class com.facebook.hiveio.log.HiveLogHelpers
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/HiveLogHelpers.java:[68,50] cannot find symbol
  symbol:   class Level
  location: class com.facebook.hiveio.log.HiveLogHelpers
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/LogHelpers.java:[37,50] cannot find symbol
  symbol:   variable Level
  location: class com.facebook.hiveio.log.LogHelpers
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/LogHelpers.java:[38,36] cannot find symbol
  symbol:   variable Level
  location: class com.facebook.hiveio.log.LogHelpers
[ERROR] /Volumes/MacintoshData/daum/opensource/hive-io-experimental/hive-io-exp-core/src/main/java/com/facebook/hiveio/log/DataNucleusLogHelpers.java:[78,23] package org.apache.log4j does not exist
[INFO] 10 errors
[INFO] -------------------------------------------------------------
nitay commented 11 years ago

Hmm I don't get that (it builds fine for me). What's your environment? Also your patch actually introduces an error:

[INFO] Scanning for projects... [ERROR] The build could not read 1 project -> [Help 1] [ERROR]
[ERROR] The project com.facebook.hiveio:hive-io-exp-core:0.16-SNAPSHOT (/Users/nitayj/code/facebook/hive-io/hive-io-exp-core/pom.xml) has 1 error [ERROR] 'dependencies.dependency.version' for log4j:log4j:jar is missing. @ line 120, column 16 [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException

nitay commented 11 years ago

No this is not good. The whole point of slf4j is to depend on the API only and let the user of the library choose which logging library to use. We should definitely be using runtime scope for these deps. What JVM are you compiling wiht?