search

facebookarchive / huxley

A testing system for catching visual regressions in Web applications.
Apache License 2.0
4.07k stars 286 forks source link

Treath different image sizes as a diff #38

Open mliljedahl opened 10 years ago

mliljedahl commented 10 years ago

I can't see why the image size not should be treathed as a diff? This commit resizes the smallest image and fills the diff with the "diffcolor".

chenglou commented 10 years ago

But the only way the size could have changed is if you specified it in the huxleyfile; if you did that, don't you already know the image's changed?

mliljedahl commented 10 years ago

You are right, I left out that I modified the huxley code to load the full page with only the width set to a fix value. Still think this commit might be useful for the community.