facebookarchive / ide-flowtype

Flow support for Atom IDE
Other
178 stars 17 forks source link

Missing information and/or Not Working? #10

Open bradennapier opened 7 years ago

bradennapier commented 7 years ago

Not sure what's up but I can't really tell if this is working. Dont have any instructions other than to install the one package so I would imagine it should be fine.

Anyway, looks like exciting stuff!

The Issue

Outline view is completely empty - no provider provided

image

Not Getting Type Hints

Type hints also do not seem to work. I do not currently see anything at all in terms of hints like shown in the screenshot.

Not Getting Autocomplete

It would appear that autocomplete does not do anything or show up at all?

Go To Definition?

I dont think this works either

wbinnssmith commented 7 years ago

hi folks, as I mentioned in #17, we're still ironing out issues on Windows. I appreciate you all digging into it and we're of course open to pull requests. cc @madjam002 @Arcanemagus

I'll update the README to reflect this prominently.

bradennapier commented 7 years ago

@wbinnssmith so I just looked at my flow logs to determine all the issues im having... it works now but..

  1. Sometimes the whole thing stops working randomly
  2. Lots of errors are not reported at all

there are more which i will add... anyway i am seeing int he language server log tons of warnings that seem suspicious. I have posted a small portion below

'.
2017-09-15 16:28:16.572 ERROR (pid:18501) nuclide-flow-rpc - Unknown return code from Flow: 110
2017-09-15 16:28:16.572 ERROR (pid:18501) nuclide-flow-rpc - Attempted to update server status after disposal
2017-09-15 16:29:59.432 WARN (pid:19222) nuclide-flow-rpc - Invalid JSON result from flow type-at-pos --json --path /Users/bradennapier/Desktop/Dash OS/IDE/projects/dash-desktop/app/screens/DealerDashboard/DealerDashboard.js 7 41. JSON:
''.
2017-09-15 16:31:50.168 ERROR (pid:19222) nuclide-flow-rpc - Unknown return code from Flow: 110
2017-09-15 16:31:50.169 ERROR (pid:19222) nuclide-flow-rpc - Attempted to update server status after disposal
2017-09-15 16:31:57.813 ERROR (pid:19665) flow-versions - There was a problem obtaining the appropriate version of flow for your project. Please check the extension logs.
2017-09-15 16:31:57.816 ERROR (pid:19665) flow-language-server - unhandledRejection { Error: Unhandled method window/showMessageRequest
    at new ResponseError (/Users/bradennapier/.atom/packages/ide-flowtype/node_modules/vscode-jsonrpc/lib/messages.js:46:28)
    at handleResponse (/Users/bradennapier/.atom/packages/ide-flowtype/node_modules/vscode-jsonrpc/lib/main.js:421:48)
    at processMessageQueue (/Users/bradennapier/.atom/packages/ide-flowtype/node_modules/vscode-jsonrpc/lib/main.js:249:17)
    at Immediate.<anonymous> (/Users/bradennapier/.atom/packages/ide-flowtype/node_modules/vscode-jsonrpc/lib/main.js:233:13)
    at runCallback (timers.js:651:20)
    at tryOnImmediate (timers.js:624:5)
    at processImmediate [as _immediateCallback] (timers.js:596:5) code: -32601 }
2017-09-15 16:34:10.729 WARN (pid:19850) nuclide-flow-rpc - Invalid JSON result from flow type-at-pos --json --path /Users/bradennapier/Desktop/Dash OS/IDE/projects/dash-desktop/app/shared/components/DebugConsole/components/DCMenu/DCMenu.js 193 42. JSON:
''.
2017-09-15 16:34:11.500 WARN (pid:19850) nuclide-flow-rpc - Invalid JSON result from flow type-at-pos --json --path /Users/bradennapier/Desktop/Dash OS/IDE/projects/dash-desktop/app/shared/components/DebugConsole/components/DCMenu/DCMenu.js 192 39. JSON:
''.
2017-09-15 16:34:32.657 WARN (pid:19850) nuclide-flow-rpc - Invalid JSON result from flow type-at-pos --json --path /Users/bradennapier/Desktop/Dash OS/IDE/projects/dash-desktop/app/screens/DealerDashboard/components/Navbar/Navbar.js 16 31. JSON:
''.
2017-09-15 16:34:45.082 WARN (pid:19850) nuclide-flow-rpc - Invalid JSON result from flow type-at-pos --json --path /Users/bradennapier/Desktop/Dash OS/IDE/projects/dash-desktop/app/screens/DealerDashboard/components/Navbar/Navbar.js 9 6. JSON:
''.
2017-09-15 16:35:04.275 WARN (pid:19850) nuclide-flow-rpc - Invalid JSON result from flow type-at-pos --json --path /Users/bradennapier/Desktop/Dash OS/IDE/projects/dash-desktop/app/screens/DealerDashboard/components/Navbar/Navbar.js 18 26. JSON:
''.
2017-09-15 16:35:06.364 WARN (pid:19850) nuclide-flow-rpc - Invalid JSON result from flow type-at-pos --json --path /Users/bradennapier/Desktop/Dash OS/IDE/projects/dash-desktop/app/screens/DealerDashboard/components/Navbar/Navbar.js 18 23. JSON:
''.
2017-09-15 16:35:07.487 WARN (pid:19850) nuclide-flow-rpc - Invalid JSON result from flow type-at-pos --json --path /Users/bradennapier/Desktop/Dash OS/IDE/projects/dash-desktop/app/screens/DealerDashboard/components/Navbar/Navbar.js 22 1. JSON:
''.
`
aleclarson commented 6 years ago

No errors are being reported for me, either.

Also, the ~/Library/Flow directory does not exist. And yes, I have the option toggled on.

Edit: I just needed to add flow-bin to the devDependencies of my project. Now ~/Library/Flow exists! And errors are being reported! 😁 🚀 🎉

bradennapier commented 6 years ago

@aleclarson are you using the resolve_dirname feature in the flowconfig? This is a bug in flow that will no longer report errors when used.

bradennapier commented 6 years ago

See Flow Issue: https://github.com/facebook/flow/issues/5180

aleclarson commented 6 years ago

@bradennapier Nope! See my edit. 😉 I was silly enough to believe a .flowconfig was all I needed.

QuinnFreedman commented 6 years ago

I am still experiencing this issue.

Diagnostics is not doing any checking, there is no auto-complete and the outline view says "No outline available." There are no errors or warnings in the atom console and no alerts, even in dev mode. It's almost just like ide-flowtype isn't installed.

I have tried everything I can think of:

  1. Flow itself is definitely working. flow is in mt PATH. flow-bin is also a dev dependency of my project and I have "scripts": { "flow": "flow" } in my package.json. When I run flow check from the terminal in my project it works exactly as I would expect.
  2. atom-ide is definitely working correctly. I installed ide-json to test and it works perfectly. All other atom plugins are disabled
  3. my .flowconfig is at the top level of the directory that is open in Atom
  4. I have tried all the ide-flowtype settings (local bin or not)
  5. I reverted flow to version 0.59.0 because I heard that they changed something about their IDE API after that version and some IDE's stopped working

Is there anything I can do?

edit: I'm on Windows 10

hikire commented 6 years ago

Same here, flatpak version on Fedora SilverBlue