search

facebookarchive / ide-flowtype

Flow support for Atom IDE
Other
178 stars 17 forks source link

when it could support Find References ? #20

Open hunght opened 7 years ago

hunght commented 7 years ago

i got Find References: Symbol references are not available for this project. so just curious when it could support

hansonw commented 7 years ago

cc @nmote

wbinnssmith commented 7 years ago

also see facebook/nuclide#689 (with which this package shares code)

@hunght this is something we'd like to have at some point too. I'll keep this issue around to track progress on this and we'll update here when the situation changes!

nmote commented 7 years ago

This is something that needs to be implemented within Flow (not in this wrapper), and I'm actively working on it. I'm not sure what it would take to integrate it here once Flow has it, but I don't imagine it would be particularly difficult.

jacobstern commented 6 years ago

@nmote Do you have a link to the relevant Flow issue for this? I'm evaluating Flow vs. TypeScript for my team and the lack of rename and find references in Flow tooling is a big gap IMO.

nmote commented 6 years ago

Oh, this is excellent timing. I'm actually working on implementing find-refs right now. I don't have an issue that I'm tracking it on, but I've mentioned it in the changelog for v0.61.0 which should be out tomorrow or Monday: https://github.com/facebook/flow/blob/v0.61/Changelog.md

It's still rough around the edges but I'm filling in cases one by one. Right now (in the v0.61 branch) it works for class members, though has no treatment for super or sub classes. It also works in some cases for top level variables.

Next on the list is global rename.

albertstill commented 6 years ago

Any update on this?

nmote commented 6 years ago

Find references is implemented in Flow. It can also be used to drive a beta version of global rename. I haven't kept track of the ide-flowtype project but I imagine it could be integrated by someone motivated.