search

facebookarchive / ide-flowtype

Flow support for Atom IDE
Other
178 stars 17 forks source link

Errors not shown on all lines when compared to flow check. #22

Open jackfranklin opened 7 years ago

jackfranklin commented 7 years ago
screen shot 2017-09-14 at 17 16 23

In the above screenshot Flow is erroring due to a branch of this function returning an object that doesn't match the type that it should. You can see flow-check spots this error and correctly calls out the call site, which is line 70. However, in Atom, I only get line 23 highlighted (I couldn't fit line 70 into the screenshot, but trust me, it's not highlighted), whereas I would expect Line 70 to also be highlighted in the UI as being invalid.

bradennapier commented 7 years ago

There are actually a ton of situations like this going on. The errors in atom are essentially useless and confusing... i thought flow just kindof sucked until I realized the cli output actually gives you helpful information! haha

jackfranklin commented 7 years ago

I've found it pretty useful so far - to be honest this is the first time where I've had to run flow check to get more of a hint of what's going on. I'm also very aware this is a new, beta thing so I'm happy to try it out and feedback when I can :)