facebookarchive / ide-flowtype

Flow support for Atom IDE
Other
178 stars 17 forks source link

Flow binary version management #51

Open mattcollier opened 6 years ago

mattcollier commented 6 years ago

I understand that it is recommended that one specify the flow binary version in the .flowconfig file as per https://flow.org/en/docs/config/version/

I installed ide-flowtype a few days ago, when v0.62.0 was the current version of the flow binary. Versions 0.63.0 and 0.63.1 were released earlier today. Since I have Automatically download and manage Flow binaries from GitHub enabled in settings, I expected that the 0.63.x releases would be detected, downloaded and utilized in a project where there was no version specified in the .flowconfig file. The log file indicates that the 0.62.0 release was continuing to be used.

When I did specify the 0.63.1 version in the .flowconfig file, that version was downloaded and utilized properly for that project.

Then I thought, OK, now that I have 0.63.1, it will likely be used automatically by a project that did not have a specified version in it's .flowconfig file. That was not the case, and v0.62.0 continued to be used there.

So, a few thoughts about this:

  1. It does not appear that the flow binary version being used by a project is made available via the UI, I think it would be good if this information were exposed.
  2. A warning/recommendation that the flow binary version should be specified in the .flowconfig file would be a nice feature.
  3. Available update notifications when new flow binary versions are available would be nice.
  4. Since 1-3 are feature requests, a more detailed description of how the automatic download feature is currently implemented would be good here: https://github.com/flowtype/ide-flowtype#flow-version-management