search

facebookarchive / ide-flowtype

Flow support for Atom IDE
Other
178 stars 17 forks source link

Flow `0.66` compatibility #61

Open pascalduez opened 6 years ago

pascalduez commented 6 years ago

Hi,

the new error format of flow@0.66 is not displayed correctly.

screenshot from 2018-02-23 00-14-27

wbinnssmith commented 6 years ago

cc @calebmer @nmote if you have any insight off the top of your head

either way I'll look into this soon. Thanks for reporting @pascalduez!

nmote commented 6 years ago

@wanderley updated Nuclide for the new Flow error messages. Honestly I'm not 100% sure how this package is related, is it just forked from Nuclide? Anyway probably something similar to what happened in https://github.com/facebook/nuclide/commit/d3c82ef258fc6504e848b3dbe1739a912a51ed1a needs to happen here.

wbinnssmith commented 6 years ago

I just synced up with the latest code from Nuclide. flow-language-server now forwards on the trace in the form of the RelatedLocations proposal.

Unfortunately this is still a proposal, and atom-languageclient doesn't yet implement it (cc @damieng). That said, @ljw1004's proposal suggests servers keep diagnostics messages self-contained without this extra context, and I'll see what I can do to provide it. Unfortunately there isn't a client capability for this, so I can't tell exactly in which situations to expand the diagnostic message.

Going to keep this open to track progress.