search

facebookarchive / instant-articles-builder

Instant Articles Rules Editor
https://facebook.github.io/instant-articles-builder
Other
125 stars 67 forks source link

chore: add node badge to README #138

Open jhonatantft opened 4 years ago

jhonatantft commented 4 years ago

Related issue: https://github.com/facebook/instant-articles-builder/issues/22

What changes this code is introducing?

facebook-github-bot commented 4 years ago

Hi @jhonatantft!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jhonatantft commented 4 years ago

@pestevez Could you review it please?

pestevez commented 3 years ago

Apologies for the delayed response, @jhonatantft. The changes look good. Would you mind sharing how you landed at that specific version being the minimum one supported?

jhonatantft commented 3 years ago

@pestevez Thanks for the answer. I managed to get to that specific version by doing tests with each Node version. In the older version than this, I received several errors and was unable to use the application properly.

pestevez commented 3 years ago

I tried with version 8.11.3 (one lower than the one proposed) and it worked, but it didn't work with version 8.0.0. I am fine with keeping the one you have, since anyway the LTS version of node as of today is 14.15.5.

Can you please rebase, run npm install, AND include the package-lock.json file in your PR? Thanks again.

jhonatantft commented 3 years ago

Done! @pestevez

pestevez commented 3 years ago

You'll have to rebase again since we merged another PR that modified the lock file. I can take another look after you repeat the same steps described above.