Fix select value warning - Githubissues

facebookarchive / instant-articles-builder

Instant Articles Rules Editor

https://facebook.github.io/instant-articles-builder

Other

125 stars 67 forks source link

Fix select value warning #28

Closed pestevez closed 6 years ago

pestevez commented 6 years ago

This PR fixes an issue where React was generating a warning complaining about the use of the selected attribute in the select DOM element.

Steps to reproduce the fixed issue

Run the app
Load the developer console
Load a rule with properties e.g. Global
Load an HTML page e.g. the sample article
Type a selector that will match at least an element e.g h1, h2
Check the developer console

Expected result

No warnings are raised

Actual result

The following warning is shown:

Warning: Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option>.