Prevent overriding existing content attribute - Githubissues

facebookarchive / instant-articles-builder

Instant Articles Rules Editor

https://facebook.github.io/instant-articles-builder

Other

125 stars 67 forks source link

Prevent overriding existing content attribute #41

Closed pestevez closed 6 years ago

pestevez commented 6 years ago

This PR prevents overriding the content attribute when it exists in a DOM element. For example in <meta property="og:image" content="https://example.com/image.jog" />.

I did not add any tests because the change is small, we still don't have any tests for the injected code, and I want to move fast and focus in other fixes; but if it anyone feels it is required I am happy to add tests.

Test Plan

Load the sample article
Add the Global Rule (Article Structure)
Set html as rule selector
Set meta[property="og:image"] as selector for the Hero Image
Verify you see the content attribute with the URL of the image as value

pestevez commented 6 years ago

Thanks, @diegoquinteiro. Please let me know if now looks good to you.