search

facebookarchive / ios-snapshot-test-case

Snapshot view unit tests for iOS
MIT License
2.66k stars 253 forks source link

Trims away the module names on Swift classes #219

Closed dzenbot closed 6 years ago

dzenbot commented 7 years ago

Calling NSStringFromClass in Objc for Swift classes creates long strings in form of "Module.Class".

To be consistent with the Objc style, specially noticeable on reference paths, this patch trims away the module names on Swift classes.

Important: Merging this could cause tests to fail for users that are currently testing Swift classes, since the image references may not be found.

alanzeino commented 6 years ago

Hey there! We just moved the repo over here:

https://github.com/uber/ios-snapshot-test-case

Sorry to make you do this, but if you recreate the pull request we'll review it in the new repo.

Thanks!

dzenbot commented 6 years ago

Closing in favor of https://github.com/uber/ios-snapshot-test-case/pull/8