Implement Xcode 9 integration using XCTAttachment API

facebookarchive / ios-snapshot-test-case

Snapshot view unit tests for iOS

MIT License

2.66k stars 253 forks source link

Implement Xcode 9 integration using XCTAttachment API #230

Open SiarheiFedartsou opened 7 years ago

SiarheiFedartsou commented 7 years ago

XCTest in Xcode 9 has a great new feature called attachments. It allows to add attachments to test results. So we can add our captured, reference and diff images to test if it was failed(see example on screenshot).

SiarheiFedartsou commented 7 years ago

@alanzeino Thanks for your response! Just updated my pull request. Also I think that you meant tvOS, not macOS?

alanzeino commented 7 years ago

Yep, I meant tvOS. Sorry! Hopefully the project maintainer merges this one soon.

jakeatoms commented 7 years ago

Is there a plan to merge and release this? Would love to start using it now!

fassko commented 7 years ago

Where are maintainers of this library? :(

remirobert commented 7 years ago

@fassko the project is in the facebookarchive. Does that mean there are no maintainers?

alanzeino commented 6 years ago

Hey there! We just moved the repo over here:

https://github.com/uber/ios-snapshot-test-case

Sorry to make you do this, but if you recreate the pull request we'll review it in the new repo.

Thanks!

delebedev commented 6 years ago

@SiarheiFedartsou are you still keen to have it merged? I could do it for you, just need to figure how I do "commit together" to leave the credits in git history.

I'm currently using own fork with this change applied and it's a tad inconvinient.

SiarheiFedartsou commented 6 years ago

@garnett yes, still want to merge it, but I’m procrastinating to recreate the PR :) will be very thankful if you will do it for me 👍