Open SxMShaDoW opened 7 years ago
@SxMShaDoW Were you able to solve this? I am experiencing a similar issue.
@cdrage - we forked and are troubleshooting it. We also cleaned up a lot of the code to make it more usable. We will submit a PR in the future once we determine the necessary changes (if they are needed) will try to have an update for you in the next few days.
Awesome, that would be more than welcome!
Current implementation of Mention bot's Git Blame tries to display a github page and pull the information directly from it. This works on normal github because you don't need to auth in order to view the screen. Unfortunately this doesn't work on Enterprise if you require auth to view pages.
If you are using GHE 2.10, it may be possible to use the GraphQL api, but since we aren't on that yet, we aren't going that route (probably another few months before we upgrade).
We are looking into creative ways of getting the blame information from using github api (probably a mix of pull requests, history, commits, and users). Also open to other suggestions.
We may submit a PR without this functionality that has a few more toggles added and cleaned up code before then. Will let you know in the near future.
Summary:
I am currently trying to use mention-bot with github enterprise and it seems to never return potential reviewers.
Github Enterprise: 2.8 Mention bot: 3.0.2
.mention-bot
(using default config) https://github.com/facebook/mention-bot/blob/master/server.js#L126-L147
package.json
Steps to Reproduce:
git clone https://github.intuit.com/facebook/mention-bot.git
and modify files abovedocker build -t mention-bot .
docker run -e GITHUB_TOKEN="some_token" --network=host -p 5000:5000 -d mention-bot
Output (which is okay):
Output when webhook is sent
(Verified connectivity from enterprise to mention-bot ):
Verified connectivity from mention-bot to enterprise
(changed the default config to use
alwaysNotifyForPaths
and then it comments on the PR.)Any recommendations would be great.